[docs] adds feedback component #8507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 10, 2019 15:51
* publisher-production: [docs] fix SDK support for symbol-sort-key (#8501) v1.1.1 fix #8481, unbounded memory growth in IE (#8490) fix race condition between caching and aborting (#8472) swap map-tiles example to use https (#8482) set antialias to true for custom layers and extrusion examples (#8474) update examples to use mapbox-gl-geocoder v4.4.1 (#8451) manually strip urls for faster cache matching (#8434) (#8449)
colleenmcginnis
approved these changes
Jul 18, 2019
HeyStenson
approved these changes
Jul 18, 2019
|
👋 @mapbox/gl-js this is ready to go, but we wanted to be mindful of merging since this PR makes changes to |
|
@katydecorah can we wait until Monday to merge this? we're working on creating a new release and having some issues with merging |
@ryanhamley definitely! I'll check back in on Monday |
|
@ryanhamley are we clear to merge this today? |
|
Yep you're good to go @katydecorah thanks! |
mourner
added a commit
that referenced
this pull request
Jul 30, 2019
* origin/publisher-production: update version to v1.2.0 (#8562) Fix usage of String.includes which is es6 but not transformed by buble (#8565) (#8573) [docs] fix missing location prop to feedback component (#8554) Fix typo [docs] update dr-ui (#8548) [docs] fix errors on IE11 caused by dr-ui dependencies (#8544) updates directions plugin version (#8536) add dds sdk support squash (#8529) [docs] adds feedback component (#8507)
mourner
pushed a commit
that referenced
this pull request
Jul 30, 2019
* [docs] add feedback component * Update dr-ui * eslint * update dr-ui, fixes mapbox/dr-ui#157
mourner
pushed a commit
that referenced
this pull request
Jul 30, 2019
* [docs] add feedback component * Update dr-ui * eslint * update dr-ui, fixes mapbox/dr-ui#157
mourner
pushed a commit
that referenced
this pull request
Jul 30, 2019
* [docs] add feedback component * Update dr-ui * eslint * update dr-ui, fixes mapbox/dr-ui#157
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a feedback component to bottom of pages and sections. This component is currently on all docs.mapbox.com sites and it looks like this:
The component will appear at the end of:
Note: since the Style spec's subsections tend to be shorter than subsections on the API page, we decided to only place the component at the end of each Style spec section.
After the launch of this final site, look out for an internal post from the docs team where we'll share how teams can review ratings for given sites and pages. We'll also share how the docs team is triaging this feedback on a daily basis.
Ref https://github.com/mapbox/documentation/issues/209
Launch Checklist
How to test
yarn run start-docs